*FIXED 5.9* In-Battle potion and spell healing fails

[Sora]

Battle potions didnt seem to work for me, and kept getting some sort of crtical synth error #4 tell a GM thing during fights.

[Dlorak]

Battle potions didnt seem to work for me, and kept getting some sort of crtical synth error #4 tell a GM thing during fights.

elaborate, please?

how did battle potions not work? did you not receive the healing you were expecting? Did your HP go over max?

what rough percentage of health were you at before using the potion? did the potion become empty? (FYI, the last heal that makes a potion go to empty was bugging out in testing too)

[Ohric]

I also get critical sync error #4 when in a duel... It happens when i use holy heal.

i would be anywhre between 40%-70% health when this happens. the health bar and stats do not update on screen..
This happens almost all the time when i fight *Minervas Worst Nightmare* (aka... *Ohrics Punching Bag*) when i healed i got this error (Some times twice). Because the HP bar did not update i did the Holy Heal again and... again.. Then i hit him and my bar filled up. and i had 17405/17405 as the test.. but i'm sure that my hp was over full becuase i took about 6 hits from him b4 the bar even moved.

It seems that the error over filled my HP on that occasion. but i ahve not been able to repeat this event since.

[Sora]

I would not get any HP back.  My turn would be used but no HP return.  Then randomly I would get this critical synth error like 10 times in 1 fight with HP being restored at random.

[Dlorak]

3 places were broken:
- players with mods can heal. This one was your problem, sora.
- final usage of potion was doubling players HP, but in display only.
- various cap-checks weren't including HP mods (oops! stark reminder of how fresh this battle code is). This was your problem Ohric.

[fingolfin]

I created a new char and wanted to duel a boss. The Battle potion was not working for me, It just said I attacked the boss with potion, did zero damage, and i received no healing.